Merged
Conversation
MrAlias
force-pushed
the
handler-pkg
branch
8 times, most recently
from
80e2c07 to
8d31960
Compare
MrAlias
force-pushed
the
handler-pkg
branch
4 times, most recently
from
1840d60 to
b0f8ad0
Compare
MrAlias
force-pushed
the
handler-pkg
branch
2 times, most recently
from
bf5697b to
747f87b
Compare
RonFed
reviewed
Feb 26, 2025
MrAlias
commented
Feb 27, 2025
MrAlias
force-pushed
the
handler-pkg
branch
2 times, most recently
from
cb475bb to
1a2310e
Compare
RonFed
reviewed
Mar 2, 2025
MrAlias
force-pushed
the
handler-pkg
branch
7 times, most recently
from
9a57c35 to
7892744
Compare
This reverts commit 07f6558.
Use a concrete Handler struct with fields for each signal of handling. Remove the export.Telemetry type.
RonFed
approved these changes
Apr 9, 2025
Contributor
RonFed
left a comment
RonFed
left a comment
There was a problem hiding this comment.
wrote a few nits, looks great 🚀
This was referenced Apr 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1398
Adds a new
pipelinepackage to theautopackage. This package contains a newHandlerinterface that is used by theauto.Instrumentationto handle export of telemetry.